agent: shutdown connection on node stop

[stevvooe]

Closes #1274.

Signed-off-by: Stephen J Day [email protected]

cc @LK4D4 @aaronlehmann @tonistiigi

[LK4D4]

I think @aaronlehmann meant another connection. I think that connection can be just cleaned up with defer in runAgent.

[codecov-io]

Current coverage is 54.80% (diff: 0.00%)

Merging #1277 into master will increase coverage by 0.03%

@@             master      #1277   diff @@
==========================================
  Files            78         78          
  Lines         12440      12429    -11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           6814       6812     -2   
+ Misses         4683       4678     -5   
+ Partials        943        939     -4   

Powered by Codecov. Last update 0add0ab...f6abeca

[stevvooe]

I think @aaronlehmann meant another connection. I think that connection can be just cleaned up with defer in runAgent.

Indeed. Don't we still need to shut this one down?

[LK4D4]

@stevvooe At first I thought that yes, but now I believe that it will always be closed here https://github.com/stevvooe/swarmkit/blob/9720c3aff5db28dc5e46555b4e4c790bc9db392b/agent/node.go#L571 because context will be closed here https://github.com/stevvooe/swarmkit/blob/9720c3aff5db28dc5e46555b4e4c790bc9db392b/agent/node.go#L175

[stevvooe]

@LK4D4 Fair enough.

[LK4D4]

LGTM

[aaronlehmann]

LGTM