Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

docker scan does not handle Ctrl-C #146

Open
gtardif opened this issue Mar 31, 2021 · 2 comments
Open

docker scan does not handle Ctrl-C #146

gtardif opened this issue Mar 31, 2021 · 2 comments
Labels
bug 🐞 App is not working correctly.

Comments

@gtardif
Copy link
Contributor

gtardif commented Mar 31, 2021

No description provided.

@gtardif gtardif added the bug 🐞 App is not working correctly. label Mar 31, 2021
@gtardif
Copy link
Contributor Author

gtardif commented Apr 6, 2021

@thaJeztah I could not reproduce this, did you actually Ctrl-C in a terminal or was it sending a kill signal to the docker scan invocation ?
I think sending a kill signal, the docker-cli will not propagate the signal to CLI plugins, but in a terminal, Ctrl-C will send the signal to processes in the same process group, therefore also cancelling the cli plugin execution.
To handling the kill signal we need a fix in docker/cli on CLI plugins in order to forward signals to child processes (I'd like to issue a PR when I have time on this).

@gtardif
Copy link
Contributor Author

gtardif commented Apr 6, 2021

Actually I can reproduce (only on linux, behaviour is different on mac/win).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🐞 App is not working correctly.
Projects
None yet
Development

No branches or pull requests

1 participant