command to purge all keys from all delegations below a starting point #855
Conversation
endophage
force-pushed
the
delegation_remove_key
branch
6 times, most recently
from
80ba1f0
to
abc8943
Compare
endophage
changed the title
| path.Join(CanonicalTargetsRole, "level1"): tr, | ||
| path.Join(CanonicalTargetsRole, "level1", "level2", "level3"): tr, | ||
| path.Join(CanonicalTargetsRole, "under_score"): tr, | ||
| path.Join(CanonicalTargetsRole, "hyphen-hyphen"): tr, |
There was a problem hiding this comment.
thanks for this refactoring 👍
There was a problem hiding this comment.
Just wanted consistency within the file :-)
endophage
force-pushed
the
delegation_remove_key
branch
3 times, most recently
from
4d25d99
to
34606c0
Compare
| path.Join(CanonicalSnapshotRole, "*"): f, | ||
| path.Join(CanonicalTimestampRole, "*"): f, | ||
| path.Join(CanonicalTargetsRole, "*", "foo"): f, | ||
| path.Join(CanonicalTargetsRole, "*", "*"): f, |
There was a problem hiding this comment.
Can also add failure cases for trailing slashes after the *, and extra slashes between the rest of the delegation and the *?
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
endophage
force-pushed
the
delegation_remove_key
branch
from
34606c0
to
fdf7f13
Compare
|
thank you for adding the tests, LGTM! Documentation CI errors are unrelated |
| @@ -92,6 +91,10 @@ func changeTargetsDelegation(repo *tuf.Repo, c changelist.Change) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if data.IsWildDelegation(c.Scope()) { | |||
There was a problem hiding this comment.
This is never getting exercised, which is weird because cmd/notary/integration_test.go's TestPurge should exercise this bit of code.
In applyChangelist, where we switch based on whether the scope is a delegation (L43) I think we also have to change that line to be isDel := data.IsDelegation(c.Scope()) || data.IsWildDelegation(c.Scope())
There was a problem hiding this comment.
Hmmm, you're absolutely right, and that's making me wonder why the test in cmd/notary/delegations_test.go is even passing.
Going to add some more checks to that test to try and make it fail, then will update this and see if it passes again.
There was a problem hiding this comment.
Oh, I see now. I'm calling the purge command but not publish so it's not actually applying the change. I must have got sidetracked half way through the test and forgotten to come back to it.
endophage
force-pushed
the
delegation_remove_key
branch
from
fdf7f13
to
3b3c24b
Compare
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
endophage
force-pushed
the
delegation_remove_key
branch
from
3b3c24b
to
0297730
Compare
|
Awesome, thanks for tackling this! LGTM! |
Need to write tests.Closes #696
Signed-off-by: David Lawrence [email protected] (github: endophage)