-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert docker compose files to v2 #755
Conversation
Can one of the admins verify this patch? |
Hmm..looks like the circleci test failed because it does not have high enough docker version:
|
@andrewhsu Thank you for your contribution! I'm trying to update our circle config to bump up the docker version: #756, but am still working out a few kinks |
We've merged 756 so please rebase and see if CircleCI works now. |
Signed-off-by: Andrew Hsu <[email protected]>
@endophage i've rebased, but it looks like circleci build failed again. look like https://gopkg.in is down which is preventing go from getting what it needs: https://circleci.com/gh/docker/notary/3040 |
Signed-off-by: Andrew Hsu <[email protected]>
jenkins, test this please |
@andrewhsu Thank you so much for your contribution! Apologies for the delayed response - our team has been mostly out of office at conferences and whatnot. Thank you for splitting the signer out so clients don't have to have access to the signer or DB as well. The one non-blocking nitpick I have is that "rdb" in the |
Signed-off-by: Andrew Hsu <[email protected]>
@cyli i've renamed |
jenkins, test this please |
thank you for this contribution! Tested the |
LGTM |
Converted the remaining two docker compose files over to the v2 format as suggested in #753 in hopes that the dns server in docker would resolve the hostnames of the containers instead of going off-box for hostname resolution.
Signed-off-by: Andrew Hsu [email protected]