Username and password not recognized

[slimcdk]

Behaviour

I'm using this example to authenticate with docker hub, however the build fails with the error. What am I missing?
Secrets are set. Both username, password and a PAT - nothing fixes it

Run docker/login-action@v1
  with:
    logout: true
Error: Username and password required

Configuration

name: Publish Docker image
on:
  push:
    tags:
      - v*

jobs:
  push_to_registry:
    name: Push Docker image to Docker Hub
    runs-on: ubuntu-latest
    steps:
      - name: Check out the repo
        uses: actions/checkout@v2

      - name: Login to DockerHub
        uses: docker/login-action@v1 
        with:
          username: ${{ secrets.DOCKER_USERNAME }}
          password: ${{ secrets.DOCKER_TOKEN }}
          logout: true

      - name: Push to Docker Hub
        uses: docker/build-push-action@v2
        with:
          push: true
          tags: <removed>:latest

      - name: Image digest
        run: echo ${{ steps.docker_build.outputs.digest }}

[crazy-max]

@slimcdk Do you have a link to your repo or logs of your build?

[slimcdk]

Yea, I'll let it be public for the regards of this issue. It is here https://github.com/MSDO-ImageHost/Posts

[slimcdk]

I had commented out the username and password as I was trying something else. When I reverted to username and password again, it worked...

[crazy-max]

@slimcdk Ok, get back to me if you reproduce the issue.

[kushthedude]

@crazy-max We are facing this same issue here https://github.com/layer5io/meshery/pull/1952/files, here are the logs https://github.com/layer5io/meshery/pull/1952/checks?check_run_id=1430712858

[kushthedude]

This is making it very difficult to debug as logs are quite ambiguous given I have already set-up repo secrets

[crazy-max]

@kushthedude Secrets are not passed to the runner when a workflow is triggered from a forked repository.

[kushthedude]

Makes sense, got it

[tobiolusa]

Still having similar issue.
Error: Username and password required

[elvisAR-git]

Yeah, me too. Any Fix, please :)

[harshraj22]

Same issue.

[lhcunha]

Have you tried to use the docker/[email protected] instead of docker/login-action@v1 ?
Also, I'd try to run it without logout: true .

[mdeous]

I'm facing the same issue (docker/[email protected]). I have a workflow with a matrix to push both to ghcr.io and docker.io, and while the job for ghcr.io has the password properly passed to it, the output for the job for docker.io looks like no password was passed at all and fails with a Username and password required error. The definition of my GH workflow can be found here.

The error seems to happen / stop happening more or less randomly, and in my case only with docker.io. I had the issue in the past, disabled my job for docker.io, then I re-enabled it some time later and it worked again, and now after upgrading the action to its latest version the issue is back.

[leocavalcante]

Facing the same issue at opencodeco/phpctl#36