Forcing a nil IP specified in PortBindings to IPv4zero (0.0.0.0). #2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a different key for the port mapper.
During AllocatePorts, the portbindings hostIP was nil. So, the key to the port mapper was <HostIP:nil, host port, etc...>
However, during ReleasePorts, the portbindings hostIP was 0.0.0.0. So, the key to port mapper was <HostIP:0.0.0.0, host port, etc...>
Since thoe HostIP was different (nil vs 0.0.0.0), we never removed the entry from the port mapper. This resulted in us leaking all the port bindings in port mapper.
Signed-off-by: Pradip Dhara [email protected]