Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker CLI winget package symlink encoding bug #14343

Open
codekoenig opened this issue Sep 28, 2024 · 2 comments
Open

Docker CLI winget package symlink encoding bug #14343

codekoenig opened this issue Sep 28, 2024 · 2 comments
Labels

Comments

@codekoenig
Copy link

Description

When I install the Docker CLI on Windows via the windows package manager (winget), it creates symlinks to the actual executables, within the current user's AppData folder.

But if the username contains Umlauts (ö, ä, ü) and likely any other non-English characters, it uses the wrong encoding for the symlinks target:

image

Reproduce

On a clean Windows instance without any Docker stuff installed run:

winget install Docker.DockerCLI

Expected behavior

Symlinks are created with correct UTF encoding

docker version

Client:
 Version:           27.3.1
 API version:       1.41 (downgraded from 1.47)
 Go version:        go1.22.7
 Git commit:        ce12230
 Built:             Fri Sep 20 11:42:27 2024
 OS/Arch:           windows/amd64
 Context:           default

docker info

Client:
 Version:    27.3.1
 Context:    default
 Debug Mode: false

Additional Info

No response

@thaJeztah
Copy link
Member

Thanks for reporting; I'm not actually sure if that package (through winget) is maintained by Docker; I see the page mentions "Docker, Inc." but the official installation instructions for Docker Desktop are at https://docs.docker.com/desktop/install/windows-install/

At least the winget.run domain looks to be very outdated, as it shows 4.17 as latest version (which is very old);

Screenshot 2024-10-01 at 14 09 18

I did find this repository that seem to be defining these packages; https://github.com/microsoft/winget-pkgs/blob/master/manifests/d/Docker/DockerDesktop/4.34.2/Docker.DockerDesktop.yaml

That one seems to be using the install --quiet option from the downloaded installer;
https://github.com/microsoft/winget-pkgs/blob/9e3e859046eae9f199adf17e5669419bb9575ba3/manifests/d/Docker/DockerDesktop/4.34.2/Docker.DockerDesktop.installer.yaml#L13-L24

if that's causing the issue, then this ticket should probably be moved to the docker desktop for windows issue tracker; let me move it there.

@thaJeztah thaJeztah transferred this issue from docker/cli Oct 1, 2024
@codekoenig
Copy link
Author

codekoenig commented Oct 1, 2024

Thanks for looking into this!

I did find the winget.run domain too, but this seems not to be an official website from Microsoft. It also does not contain the CLI package.

Be aware that I was not talking about the Docker Desktop package, but about CLI only (Docker.DockerCLI) which is this package: https://github.com/microsoft/winget-pkgs/blob/master/manifests/d/Docker/DockerCLI/27.3.1/Docker.DockerCLI.yaml

Glad you found the package repo ... because looking at this package files, it does not seem that the package itself defines the symlinks that are created with wrong encoding and they might be something that gets implicitly created by winget package manager for the EXE files contained in the referenced ZIP file. So this might be a winget issue after all and not have directly something to do with the Docker.DockerCLI package ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants