Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.06.0 RC4 tracker #14

Closed
2 tasks done
andrewhsu opened this issue Jun 13, 2017 · 8 comments
Closed
2 tasks done

17.06.0 RC4 tracker #14

andrewhsu opened this issue Jun 13, 2017 · 8 comments

Comments

@andrewhsu
Copy link
Contributor

andrewhsu commented Jun 13, 2017

STATUS: completed merge of PR with desired cherry-picks

@andrewhsu andrewhsu mentioned this issue Jun 13, 2017
40 tasks
@thaJeztah
Copy link
Member

@cpuguy83 @dnephin I think moby/moby#33422 and moby/moby#33500 can be removed, as they are already in, correct?

@dnephin
Copy link

dnephin commented Jun 13, 2017

moby/moby#33500 is in. marked it in the descirption

@cyli
Copy link

cyli commented Jun 14, 2017

Not sure if we should add moby/swarmkit#2224 as well - it's more of a p1 or p2, but it's also a minor change. I've opened the PR in case.

@mavenugo
Copy link

@cyli as discussed, we are targeting only p0s for RC4.

@cyli
Copy link

cyli commented Jun 16, 2017

One p1 or p2 usability issue, so it can wait for 17.06.1, except that this may be an API change (to an API introduced in 17.06), so maybe wouldn't be able to make it into 17.06.1 if it doesn't make it into 17.06:

Currently when you update the swarm spec to do a CA rotation to a specific cert and key, you update the swarm CAConfig spec. When we return this info to you in the engine, we redact the key, because that's secret. However, if you want to do the usual get+update flow, the spec you are posting has the key set to empty, so swarm will interpret this as "you want to remove the key from the swarm".

The following PRs also redact the signing cert, so when you update without changing those two values in the CA config, it's not changing anything:

The CLI does not need an update because if there is nothing in the CAConfig signing cert field, it does not actually print out anything.

@docker docker deleted a comment from aaronlehmann Jun 16, 2017
@cyli
Copy link

cyli commented Jun 16, 2017

@aaronlehmann Uh, I don't know what I did (I just swiped across my trackpad), but apparently I deleted a comment from you? :( I didn't see any comment though. Sorry!

@aaronlehmann
Copy link

Probably a link to docker-archive/docker-ce#75. Can't be important at this point.

@andrewhsu
Copy link
Contributor Author

I've moved the backlog to a new issue to a new issue #37 for RC5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants