This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[18.09 backport] BuildKit fixes for 18.09.1 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to keep the UX consistent. `unused-for` is still accepted and a synonym. Signed-off-by: Tibor Vass <[email protected]> (cherry picked from commit 369da26)
Signed-off-by: Tibor Vass <[email protected]> (cherry picked from commit 62923f2)
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit effb2bd)
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 6204eb0)
tiborvass
approved these changes
Nov 21, 2018
|
Upstream changes in buildkit: moby/buildkit@c7bb575...8cf9bec |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in following:
unused-forin favor ofuntilmoby/moby#38238Possibly could also use "builder: add workaround for gcr auth issue" moby#38246 but needs upstream reviews first
@tiborvass @thaJeztah