Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect document content for bake/inheritence/overriding-inherited-attributes #22203

Open
1 task done
Aden-Q opened this issue Mar 8, 2025 · 0 comments
Open
1 task done
Labels
area/build Relates to Dockerfiles or docker build command status/triage Needs triage

Comments

@Aden-Q
Copy link

Aden-Q commented Mar 8, 2025

Is this a docs issue?

  • My issue is about the documentation content or website

Type of issue

Information is incorrect

Description

In the bake/inheritance/overriding-inherited-attributes section of the document. The given docker-bake.hcl declaration example shows a app-dev target inherited from the _common target:

// docker-bake.hcl
target "app-dev" {
  inherits = ["_common"]
  args = {
    GO_VERSION = "1.17"
  }
  tags = ["docker.io/username/myapp:dev"]
}

Howver, the description below:

The GO_VERSION argument in app-release is set to 1.17, overriding the GO_VERSION argument from the app-dev target.

The description is not related to the example given about.

Location

https://docs.docker.com/build/bake/inheritance/

Suggestion

Either by giving an new example docker-bake.hcl so it's related to the description:

// docker-bake.hcl
target "app-release" {
  inherits = ["app-dev"]
  args = {
    GO_VERSION = "1.17"
  }
  tags = ["docker.io/username/myapp:dev"]
}

Or by rewording the description:

The GO_VERSION argument in app-devis set to 1.17, overriding the GO_VERSION argument from the _common target.
@Aden-Q Aden-Q added the status/triage Needs triage label Mar 8, 2025
@Aden-Q Aden-Q changed the title incorrect document content for inheritence Incorrect document content for bake/inheritence/overriding-inherited-attributes Mar 8, 2025
@thaJeztah thaJeztah added the area/build Relates to Dockerfiles or docker build command label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command status/triage Needs triage
Projects
None yet
Development

No branches or pull requests

2 participants