remove aufs "default storage driver" statements #7433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases, aufs is no longer the default storage driver, so just change the example to not mention the default. If you'd like it to actually state overlay2 is the default in most/some cases I can change that.
|
Deploy preview for docsdocker ready! Built with commit 261bd20 |
thaJeztah
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
Thanks! LGTM
Off-topic, but looking at this 🤔 we should start deprecating the overlay driver; IIRC, with the Red Hat kernels now supporting overlay2, every supported distro that supports overlay now also supports overlay2, and I cannot think of any reason to use overlay instead of overlay2 for those.
storage/storagedriver/index.md
Outdated
| @@ -292,8 +292,8 @@ layer. This means that the writable layer is as small as possible. | |||
|
|
|||
| When an existing file in a container is modified, the storage driver performs a | |||
| copy-on-write operation. The specifics steps involved depend on the specific | |||
| storage driver. For the default `aufs` driver and the `overlay` and `overlay2` | |||
| drivers, the copy-on-write operation follows this rough sequence: | |||
| storage driver. For the `aufs`, `overlay` and `overlay2` drivers, the | |||
There was a problem hiding this comment.
nit: the documentation uses Oxford comma, so there should be a comma before and overlay 😅
(just a nit, so I'm ok with merging as-is, if it's not updated)
bermudezmt
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In many cases,
aufsis no longer the default storage driver, so I just changed the examples to not mention the default. If you'd like it to actually state overlay2 is the default in most/some cases I can change that, but felt it was best left to the "Selecting a storage driver" page.