Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Aug 26, 2025

What I did
as we produce a bake.json with all environment variables resolved, do not propagate the whole project.Environement to run bake, which includes variables set by .env file

Related issue
fixes #13157

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof marked this pull request as ready for review August 26, 2025 07:20
@ndeloof ndeloof requested a review from a team as a code owner August 26, 2025 07:20
@ndeloof ndeloof requested a review from glours August 26, 2025 07:20
@ndeloof
Copy link
Contributor Author

ndeloof commented Aug 26, 2025

cc @maxproske

Signed-off-by: Nicolas De Loof <[email protected]>
@glours glours merged commit b387ba4 into docker:main Sep 8, 2025
26 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Sep 10, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.39.2` -> `v2.39.3` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.39.3`](https://github.com/docker/compose/releases/tag/v2.39.3)

[Compare Source](docker/compose@v2.39.2...v2.39.3)

#### What's Changed

##### ✨ Improvements

- Add completions for the `--progress` flag by [@&#8203;m4rch3n1ng](https://github.com/m4rch3n1ng) in [#&#8203;13158](docker/compose#13158)

##### 🐛 Fixes

- Add `--provenance` and `--sbom` flag to generated `bake` command line, by [@&#8203;glours](https://github.com/glours) in [#&#8203;13147](docker/compose#13147)
- Fix runtime operations failing when env file is missing by [@&#8203;maxproske](https://github.com/maxproske) in [#&#8203;13156](docker/compose#13156)
- Check the assume yes publish flag command before the presence of bind mounts by [@&#8203;glours](https://github.com/glours) in [#&#8203;13151](docker/compose#13151)
- Fix: incorrect time when last tag time is not set by [@&#8203;kianelbo](https://github.com/kianelbo) in [#&#8203;13171](docker/compose#13171)
- Fix sigint/sigterm support in logs `--follow` by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13193](docker/compose#13193)
- Prefer application container vs one-off running `exec` without index by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13178](docker/compose#13178)
- Only force plain mode build if progress is set to `auto` by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13181](docker/compose#13181)
- Only propagate os.Env to bake, not the whole project.Environment by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13180](docker/compose#13180)
- Detect container is restarted by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13210](docker/compose#13210)
- Fix run `--build` support for `service:* reference` in additional\_context by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13183](docker/compose#13183)
- Detect compose run wit `--host` and set `DOCKER_HOST` accordingly running bake by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13182](docker/compose#13182)

##### 🔧  Internal

- Refactor to use maps.Copy by [@&#8203;cuiweixie](https://github.com/cuiweixie) in [#&#8203;13174](docker/compose#13174)
- Replace most uses of hashicorp/go-multierror for stdlib by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13176](docker/compose#13176)
- pkg/compose: composeService.Up: rewrite without go-multierror by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13177](docker/compose#13177)
- Use enum-consts for State and Health by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13186](docker/compose#13186)
- Unquote volume names in creation events by [@&#8203;rrjjvv](https://github.com/rrjjvv) in [#&#8203;13188](docker/compose#13188)
- pkg/compose: use state consts from moby API by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13216](docker/compose#13216)
- Document (hidden) `--tty` `--interactive` flags by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13201](docker/compose#13201)

##### ⚙️ Dependencies

- go.mod: github.com/docker/buildx v0.27.0 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13170](docker/compose#13170)
- Build(deps): bump go.uber.org/mock from 0.5.2 to 0.6.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13162](docker/compose#13162)
- go.mod: bump buildkit v0.24.0-rc1, buildx v0.28.0-rc1 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13185](docker/compose#13185)
- Build(deps): bump github.com/stretchr/testify from 1.10.0 to 1.11.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13184](docker/compose#13184)
- go.mod: bump buildx v0.28.0-rc2, buildkit v0.24.0-rc2 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13197](docker/compose#13197)
- Build(deps): bump github.com/spf13/pflag from 1.0.7 to 1.0.9 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13195](docker/compose#13195)
- Build(deps): bump github.com/spf13/cobra from 1.9.1 to 1.10.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13198](docker/compose#13198)
- go.mod: bump github.com/docker/docker, docker/cli v28.4.0 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in [#&#8203;13168](docker/compose#13168)
- Build(deps): bump github.com/docker/buildx from 0.28.0-rc2 to 0.28.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13207](docker/compose#13207)
- Build(deps): bump github.com/spf13/pflag from 1.0.9 to 1.0.10 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13200](docker/compose#13200)
- Bump golang to version 1.24.7 by [@&#8203;glours](https://github.com/glours) in [#&#8203;13219](docker/compose#13219)
- Build(deps): bump golang.org/x/sync from 0.16.0 to 0.17.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13218](docker/compose#13218)
- Build(deps): bump golang.org/x/sys from 0.35.0 to 0.36.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13217](docker/compose#13217)
- Bump compose-go to version v2.8.2 by [@&#8203;glours](https://github.com/glours) in [#&#8203;13220](docker/compose#13220)

#### New Contributors

- [@&#8203;cuiweixie](https://github.com/cuiweixie) made their first contribution in [#&#8203;13174](docker/compose#13174)
- [@&#8203;m4rch3n1ng](https://github.com/m4rch3n1ng) made their first contribution in [#&#8203;13158](docker/compose#13158)
- [@&#8203;kianelbo](https://github.com/kianelbo) made their first contribution in [#&#8203;13171](docker/compose#13171)
- [@&#8203;rrjjvv](https://github.com/rrjjvv) made their first contribution in [#&#8203;13188](docker/compose#13188)

**Full Changelog**: <docker/compose@v2.39.2...v2.39.3>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OC4xIiwidXBkYXRlZEluVmVyIjoiNDEuOTguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Delays in build time when environment files have OTEL-related values and built with bake

2 participants