Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COMPOSE_MENU env from e2e tests #11654

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

jhrotko
Copy link
Contributor

@jhrotko jhrotko commented Mar 22, 2024

What I did
Removed COMPOSE_MENU from env in Dockerfile and Makefile
Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@jhrotko jhrotko requested a review from milas March 22, 2024 20:44
@jhrotko jhrotko self-assigned this Mar 22, 2024
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but tbh the more I think about it, it seems like we shouldn't need to specify COMPOSE_MENU / --menu for tests at all, I'd assume everything would be detected as NOT a TTY and thus not try to show the menu 🤔

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.76%. Comparing base (cc09f39) to head (4170c47).
Report is 25 commits behind head on main.

Current head 4170c47 differs from pull request most recent head 769ec5a

Please upload reports for the commit 769ec5a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11654      +/-   ##
==========================================
+ Coverage   54.52%   54.76%   +0.23%     
==========================================
  Files         145      145              
  Lines       12694    12585     -109     
==========================================
- Hits         6922     6892      -30     
+ Misses       5071     4999      -72     
+ Partials      701      694       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @milas we should not have the --menu in e2e test, Compose should detect TTY isn't available when running e2e in CI

@ndeloof
Copy link
Contributor

ndeloof commented Mar 26, 2024

if removal for COMPOSE_MENU require --menu=false to be added to all our e2e test I'd prefer we keep the variable!

@jhrotko jhrotko merged commit da43401 into docker:main Jul 1, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants