Skip to content

checkExpectedVolumes must ignore anonymous volumes #12410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 19, 2024

What I did

Related issue
fixes #12404

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@ndeloof ndeloof requested a review from glours December 19, 2024 10:14
@Jule-
Copy link

Jule- commented Jan 3, 2025

Hi, is something blocking here with this little PR? This recent bug is killing a bit of my productivity when it recreates containers I did not expect to be recreated.

Thank you!

@ndeloof
Copy link
Contributor Author

ndeloof commented Jan 3, 2025

@Jule main blocker here is named "holidays" :P

@Jule-
Copy link

Jule- commented Jan 3, 2025

@ndeloof Haha, ok perfect then! 😄 @glours Please enjoy! 😉

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit be09b2e into docker:main Jan 6, 2025
26 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 8, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v2.32.1` -> `v2.32.2` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v2.32.2`](https://github.com/docker/compose/releases/tag/v2.32.2)

[Compare Source](docker/compose@v2.32.1...v2.32.2)

#### What's Changed

##### ✨ Improvements

-   Add `--pull` to run command by [@&#8203;glours](https://github.com/glours)  [(12397)](docker/compose#12397)

##### 🐛 Fixes

-   Only check bind mount conflict if sync action is involved by [@&#8203;ndeloof](https://github.com/ndeloof) [(12409)](docker/compose#12409)
-   When retrying to resolveOrCreateNetwork, retry with a valid network name by [@&#8203;gtardif](https://github.com/gtardif)  [(12422)](docker/compose#12422)
-   checkExpectedVolumes must ignore anonymous volumes by [@&#8203;ndeloof](https://github.com/ndeloof) in docker/compose#12410

##### 🔧  Internal

-   Gofumpt all the things by [@&#8203;ndeloof](https://github.com/ndeloof) [(12392)](docker/compose#12392)
-   Use the 3 latest major versions of the engine to run e2e step by [@&#8203;glours](https://github.com/glours) [(12401)](docker/compose#12401)
-   Replace tibdex/github-app-token by official GitHub create-github-app-token by [@&#8203;glours](https://github.com/glours) [(12411)](docker/compose#12411)

##### ⚙️ Dependencies

-   Bump Golang version to `v1.22.10` and update CI actions by [@&#8203;glours](https://github.com/glours) [(12399)](docker/compose#12399)
-   Bump golang.org/x/net to `v0.33.0` to fix potential security issue by [@&#8203;glours](https://github.com/glours)  [(12405)](docker/compose#12405)
-   Bump `compose-go` to `v2.4.7` by [@&#8203;glours](https://github.com/glours) [(12438)](docker/compose#12438)

**Full Changelog**: docker/compose@v2.32.1...v2.32.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS40IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
@Jule-
Copy link

Jule- commented Jan 10, 2025

I can confirm that it now works like a charm! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v2.32.1 Anonymous volumes cause container to be re-created every time
3 participants