-
Notifications
You must be signed in to change notification settings - Fork 5.4k
checkExpectedVolumes must ignore anonymous volumes #12410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nicolas De Loof <[email protected]>
Hi, is something blocking here with this little PR? This recent bug is killing a bit of my productivity when it recreates containers I did not expect to be recreated. Thank you! |
@Jule main blocker here is named "holidays" :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.32.1` -> `v2.32.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.32.2`](https://github.com/docker/compose/releases/tag/v2.32.2) [Compare Source](docker/compose@v2.32.1...v2.32.2) #### What's Changed ##### ✨ Improvements - Add `--pull` to run command by [@​glours](https://github.com/glours) [(12397)](docker/compose#12397) ##### 🐛 Fixes - Only check bind mount conflict if sync action is involved by [@​ndeloof](https://github.com/ndeloof) [(12409)](docker/compose#12409) - When retrying to resolveOrCreateNetwork, retry with a valid network name by [@​gtardif](https://github.com/gtardif) [(12422)](docker/compose#12422) - checkExpectedVolumes must ignore anonymous volumes by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12410 ##### 🔧 Internal - Gofumpt all the things by [@​ndeloof](https://github.com/ndeloof) [(12392)](docker/compose#12392) - Use the 3 latest major versions of the engine to run e2e step by [@​glours](https://github.com/glours) [(12401)](docker/compose#12401) - Replace tibdex/github-app-token by official GitHub create-github-app-token by [@​glours](https://github.com/glours) [(12411)](docker/compose#12411) ##### ⚙️ Dependencies - Bump Golang version to `v1.22.10` and update CI actions by [@​glours](https://github.com/glours) [(12399)](docker/compose#12399) - Bump golang.org/x/net to `v0.33.0` to fix potential security issue by [@​glours](https://github.com/glours) [(12405)](docker/compose#12405) - Bump `compose-go` to `v2.4.7` by [@​glours](https://github.com/glours) [(12438)](docker/compose#12438) **Full Changelog**: docker/compose@v2.32.1...v2.32.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MS40IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
I can confirm that it now works like a charm! Many thanks! |
What I did
Related issue
fixes #12404
(not mandatory) A picture of a cute animal, if possible in relation to what you did