Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally run build checks and fail on issues #1219

Open
ferrarimarco opened this issue Aug 26, 2024 · 2 comments
Open

Optionally run build checks and fail on issues #1219

ferrarimarco opened this issue Aug 26, 2024 · 2 comments
Labels
kind/enhancement New feature or request status/triage

Comments

@ferrarimarco
Copy link

Description

Thanks for working on this action :)

The docker buildx build command exposes the useful check frontend call to check for some best practices.

Would it be possible to optionally run it before running the build, and fail if it returns any warning?

@colinhemmings
Copy link

colinhemmings commented Aug 27, 2024

Hi @ferrarimarco
Great question. We are working on a dedicated step for validating build configuration to solve this use case.

It is also possible to fail the build by adding a directive, but this will only validate the specified build target. We recommend the step I mentioned above to check the entire build configuration as a validation step for your build.

I can let you know when this new step is available, but would this approach work for you? I am keen to get feedback on how this approach works for people.

@ferrarimarco
Copy link
Author

Hi! Thanks for the recommendation. I think that the dedicated step would be best for this use case.

Our current workaround is to manually add a step that runs docker build --check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request status/triage
Projects
None yet
Development

No branches or pull requests

3 participants
@ferrarimarco @colinhemmings and others