Skip to content
This repository was archived by the owner on Mar 11, 2020. It is now read-only.

Commit bd8f9db

Browse files
committed
Remove tag defaulting in newFcall
Defaulting the tag in newFcall might result in unexpected behaviour. For example, if a client (erroneously) sends a Tversion on a tag, the server response will not be on a tag. newFcall should just create the struct. Signed-off-by: Kenny Levinsen <[email protected]>
1 parent bd8041e commit bd8f9db

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

Diff for: fcall.go

-5
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,6 @@ type Fcall struct {
111111
}
112112

113113
func newFcall(tag Tag, msg Message) *Fcall {
114-
switch msg.Type() {
115-
case Tversion, Rversion:
116-
tag = NOTAG
117-
}
118-
119114
return &Fcall{
120115
Type: msg.Type(),
121116
Tag: tag,

0 commit comments

Comments
 (0)