Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Commit 986c344

Browse files
author
Tibor Vass
committed
deb/rpm: do not call cli Makefile that is changing
In docker/cli#2993, Makefile target dynbinary changed from a host script not depending on docker to a dockerized script. Instead call the underlying script directly for deb/rpm. I still think we should build deb/rpms using docker. Signed-off-by: Tibor Vass <[email protected]> Upstream-commit: 5d52107 Component: packaging
1 parent 9c2fc45 commit 986c344

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

components/packaging/deb/common/rules

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ override_dh_auto_build:
1010
cd engine && TMP_GOPATH="/go" hack/dockerfile/install/install.sh proxy dynamic
1111
cd engine && TMP_GOPATH="/go" hack/dockerfile/install/install.sh rootlesskit dynamic
1212
# Build the CLI
13-
cd /go/src/github.com/docker/cli && \
14-
LDFLAGS='' DISABLE_WARN_OUTSIDE_CONTAINER=1 make VERSION=$(VERSION) GITCOMMIT=$(CLI_GITCOMMIT) dynbinary manpages
13+
cd /go/src/github.com/docker/cli && VERSION=$(VERSION) GITCOMMIT=$(CLI_GITCOMMIT) LDFLAGS='' GO_LINKMODE=dynamic ./scripts/build/binary && DISABLE_WARN_OUTSIDE_CONTAINER=1 LDFLAGS='' make manpages
1514

1615
# Build the scan-plugin
1716
# TODO change once we support scan-plugin on other architectures

components/packaging/rpm/SPECS/docker-ce-cli.spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ mkdir -p /go/src/github.com/docker
5151
rm -f /go/src/github.com/docker/cli
5252
ln -s ${RPM_BUILD_DIR}/src/cli /go/src/github.com/docker/cli
5353
pushd /go/src/github.com/docker/cli
54-
DISABLE_WARN_OUTSIDE_CONTAINER=1 make VERSION=%{_origversion} GITCOMMIT=%{_gitcommit_cli} dynbinary manpages # cli
54+
VERSION=%{_origversion} GITCOMMIT=%{_gitcommit_cli} GO_LINKMODE=dynamic ./scripts/build/binary && DISABLE_WARN_OUTSIDE_CONTAINER=1 make manpages # cli
5555
popd
5656

5757
# Build all associated plugins

0 commit comments

Comments
 (0)