Update simplemon widget to show only unhandled problems #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can i use these code part for my icinga2 gem? |
|
Of course :) |
bodsch
added a commit
to bodsch/ruby-icinga2
that referenced
this pull request
Jun 17, 2017
bodsch
added a commit
to bodsch/ruby-icinga2
that referenced
this pull request
Jun 18, 2017
take from mocdaniel/dashing-icinga2#18 that will be usable into any [dashing|smashing]-icinga2 environments
|
Thanks for the patch. I do have a different solution in mind already. This does not change the interface of countProblems() but adds the possibility to pass a state number or an array of state numbers (or nil which means all problems). This allows to count all unhandled problems, without any differences between CIB data and problem counts. See more details in #24 - the commits are split so you can see what I did exactly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17