change default password strength (from STRONG to NORMAL)

generate passwords where ASCII encoding and UTF-8 encoding are the same

Author: dncohen

commands.go

@@ -1052,15 +1052,15 @@ func generatePassword(reader *bufio.Reader) (password string) {
 			}
 		}
 
-		passwordStrength := encryption.STRONG
+		passwordStrength := encryption.DefaultPasswordStrength
 		for {
 			answer := strings.TrimSpace(read(reader,
-				"\nChoose a password policy:\n\nOption 1: include only latin letters.\n"+
+				fmt.Sprintf("\nChoose a password policy:\n\nOption 1: include only latin letters.\n"+
 					"Option 2: also include numbers.\n"+
 					"Option 3: also include symbols (e.g. @, !, >, $, etc.)\n"+
 					"Option 4: also include supplementary latin letters\n"+
 					"Option 5: include all extended ASCII characters, except control characters.\n\n"+
-					"Which option do you prefer? [1/2/3/4/5] (4) "))
+					"Which option do you prefer? [1/2/3/4/5] (%d) ", passwordStrength)))
 			if answer == "" {
 				break
 			} else {

encryption/crypto.go

@@ -9,7 +9,9 @@ import (
 	"crypto/sha512"
 	"errors"
 	"io"
+	"log"
 	"math/big"
+	"unicode/utf8"
 
 	"github.com/golang/crypto/argon2"
 )
@@ -46,8 +48,10 @@ const (
 
 var defaultPasswordCharRange []uint8
 
+const DefaultPasswordStrength = NORMAL
+
 func init() {
-	defaultPasswordCharRange = GetPasswordCharRange(STRONG)
+	defaultPasswordCharRange = GetPasswordCharRange(DefaultPasswordStrength)
 }
 
 // Encrypt a message given a secret key.
@@ -121,6 +125,11 @@ func createCharRange(minChar, maxChar uint8) []uint8 {
 // GetPasswordCharRange returns the appropriate char-range for the given [PasswordStrength].
 func GetPasswordCharRange(passwordStrength PasswordStrength) (charRange []uint8) {
 	if passwordStrength < WEAK || passwordStrength > STRONGEST {
+		// is this reached?
+		log.Panicf("Unexpected password strength: %d", passwordStrength)
+	}
+	if passwordStrength == DefaultPasswordStrength && len(defaultPasswordCharRange) > 0 {
+		// TODO: cache each char range after the first time it is requested
 		return defaultPasswordCharRange
 	}
 
@@ -166,6 +175,12 @@ func GeneratePassword(length int, characters []uint8) string {
 		}
 		buffer.WriteString(string(characters[int(n.Uint64())]))
 	}
+
+	// detect potential encoding problems
+	if !utf8.ValidString(buffer.String()) {
+		panic("generated password is not valid utf8")
+	}
+
 	return buffer.String()
 }