fix(Breadcrumb): icon direction on mobile when variant collapse #4452
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
force-pushed
the
fix/icon-direction-on-mobile-variant-collapse
branch
from
6cb5921 to
f9786a0
Compare
tujoworker
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Indeed. So I think we rather should change it as a feature. The new one has no icons on small screens. The text is Gå til instead of Tilbake til. Also, there is an RFC going on to make some further changes.
Update: I just got the confirmation, that the text will change to something more descriptive than Gå til.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3491
I believe this fixes the reported issue.
However, when looking into the latest Figma sketches, I don't even see any chevron icons used on small/mobile screen, https://www.figma.com/design/cdtwQD8IJ7pTeE45U148r1/Eufemia---Web?node-id=17025-0&m=dev
But the Figma sketches is probably a change we'll implement in the future? And therefore its fine to do this fix now.