forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unify BUCK and CMake includes for Cxx modules (facebook#43148)
Summary: This diff adds the `react/renderer/components` prefix to the generated `CMakeLists.txt` file for the Cxx modules. This will allow to import the generated JSI header also like this ``` #include <MyModule/MyModuleJSI.h> ``` and not just like this ``` #include "MyModuleJSI.h" ``` This will make CMake includes consistent with BUCK includes, and we'll reduce the number of awkward ifdefs in the include section. Changelog: [General][Changed] - Unify BUCK and CMake includes for Cxx modules. Differential Revision: D54063743
- Loading branch information
1 parent
f45dd4c
commit d44f48a
Showing
3 changed files
with
10 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters