You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Unify BUCK and CMake includes for Cxx modules (facebook#43148)
Summary:
This diff adds the `react/renderer/components` prefix to the generated `CMakeLists.txt` file for the Cxx modules.
This will allow to import the generated JSI header also like this
```
#include <MyModule/MyModuleJSI.h>
```
and not just like this
```
#include "MyModuleJSI.h"
```
This will make CMake includes consistent with BUCK includes, and we'll reduce the number of awkward ifdefs in the include section.
Changelog: [General][Changed] - Unify BUCK and CMake includes for Cxx modules.
Differential Revision: D54063743
Copy file name to clipboardExpand all lines: packages/react-native-codegen/src/generators/modules/__tests__/__snapshots__/GenerateModuleJniH-test.js.snap
+8-8
Original file line number
Diff line number
Diff line change
@@ -50,7 +50,7 @@ add_library(
50
50
\${react_codegen_SRCS}
51
51
)
52
52
53
-
target_include_directories(react_codegen_SampleWithUppercaseName PUBLIC . react/renderer/components/SampleWithUppercaseName)
53
+
target_include_directories(react_codegen_SampleWithUppercaseName PUBLIC . react/renderer/components react/renderer/components/SampleWithUppercaseName)
54
54
55
55
target_link_libraries(
56
56
react_codegen_SampleWithUppercaseName
@@ -137,7 +137,7 @@ add_library(
137
137
\${react_codegen_SRCS}
138
138
)
139
139
140
-
target_include_directories(react_codegen_complex_objects PUBLIC . react/renderer/components/complex_objects)
140
+
target_include_directories(react_codegen_complex_objects PUBLIC . react/renderer/components react/renderer/components/complex_objects)
141
141
142
142
target_link_libraries(
143
143
react_codegen_complex_objects
@@ -217,7 +217,7 @@ add_library(
217
217
\${react_codegen_SRCS}
218
218
)
219
219
220
-
target_include_directories(react_codegen_cxx_only_native_modules PUBLIC . react/renderer/components/cxx_only_native_modules)
220
+
target_include_directories(react_codegen_cxx_only_native_modules PUBLIC . react/renderer/components react/renderer/components/cxx_only_native_modules)
221
221
222
222
target_link_libraries(
223
223
react_codegen_cxx_only_native_modules
@@ -304,7 +304,7 @@ add_library(
304
304
\${react_codegen_SRCS}
305
305
)
306
306
307
-
target_include_directories(react_codegen_empty_native_modules PUBLIC . react/renderer/components/empty_native_modules)
307
+
target_include_directories(react_codegen_empty_native_modules PUBLIC . react/renderer/components react/renderer/components/empty_native_modules)
308
308
309
309
target_link_libraries(
310
310
react_codegen_empty_native_modules
@@ -391,7 +391,7 @@ add_library(
391
391
\${react_codegen_SRCS}
392
392
)
393
393
394
-
target_include_directories(react_codegen_native_modules_with_type_aliases PUBLIC . react/renderer/components/native_modules_with_type_aliases)
394
+
target_include_directories(react_codegen_native_modules_with_type_aliases PUBLIC . react/renderer/components react/renderer/components/native_modules_with_type_aliases)
395
395
396
396
target_link_libraries(
397
397
react_codegen_native_modules_with_type_aliases
@@ -486,7 +486,7 @@ add_library(
486
486
\${react_codegen_SRCS}
487
487
)
488
488
489
-
target_include_directories(react_codegen_real_module_example PUBLIC . react/renderer/components/real_module_example)
489
+
target_include_directories(react_codegen_real_module_example PUBLIC . react/renderer/components react/renderer/components/real_module_example)
490
490
491
491
target_link_libraries(
492
492
react_codegen_real_module_example
@@ -573,7 +573,7 @@ add_library(
573
573
\${react_codegen_SRCS}
574
574
)
575
575
576
-
target_include_directories(react_codegen_simple_native_modules PUBLIC . react/renderer/components/simple_native_modules)
576
+
target_include_directories(react_codegen_simple_native_modules PUBLIC . react/renderer/components react/renderer/components/simple_native_modules)
577
577
578
578
target_link_libraries(
579
579
react_codegen_simple_native_modules
@@ -668,7 +668,7 @@ add_library(
668
668
\${react_codegen_SRCS}
669
669
)
670
670
671
-
target_include_directories(react_codegen_two_modules_different_files PUBLIC . react/renderer/components/two_modules_different_files)
671
+
target_include_directories(react_codegen_two_modules_different_files PUBLIC . react/renderer/components react/renderer/components/two_modules_different_files)
0 commit comments