Skip to content

Commit ae15048

Browse files
dmytrorykunfacebook-github-bot
authored andcommitted
Print Hermes build script shell commands only in CI (facebook#43767)
Summary: Print Hermes build script shell commands only in CI. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D55635527
1 parent 2f1643d commit ae15048

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh

-2
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
# Defines functions for building various Hermes frameworks.
88
# See build-ios-framework.sh and build-mac-framework.sh for usage examples.
99

10-
set -x -e
11-
1210
CURR_SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
1311

1412
IMPORT_HERMESC_PATH=${HERMES_OVERRIDE_HERMESC_PATH:-$PWD/build_host_hermesc/ImportHermesc.cmake}

packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
# This source code is licensed under the MIT license found in the
55
# LICENSE file in the root directory of this source tree.
66

7-
set -x -e
7+
if [ "$CI" ]; then
8+
set -x
9+
fi
10+
set -e
811

912
# Given a specific target, retrieve the right architecture for it
1013
# $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst

packages/react-native/sdks/hermes-engine/utils/build-mac-framework.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
# This source code is licensed under the MIT license found in the
55
# LICENSE file in the root directory of this source tree.
66

7-
set -x -e
7+
if [ "$CI" ]; then
8+
set -x
9+
fi
10+
set -e
811

912
# shellcheck source=xplat/js/react-native-github/sdks/hermes-engine/utils/build-apple-framework.sh
1013
CURR_SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"

0 commit comments

Comments
 (0)