Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting when the repo has changes in the working directory should produce a visible error #611

Open
dmusican opened this issue Jun 19, 2018 · 0 comments

Comments

@dmusican
Copy link
Owner

In standard git, if you issue a "git revert" command when there are changes in the working directory present, this error results:

error: Your local changes to the following files would be overwritten by merge:
	file0
Please, commit your changes or stash them before you can merge.
Aborting

In Elegit, issuing a revert in the same situation has no effect, but there is no visible error to the user. This should happen automatically if JGit throws an exception in this case. On my preliminary investigation, it looks to me like JGit doesn't. Verify if this is true, or if we're inadvertently intercepting such an exception. if JGit really doesn't throw an exception here (yuck), we've got to check for this ourselves, and throw our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant