Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roadmap] 1.1.1 Patch Release #5735

Closed
3 tasks done
hcho3 opened this issue May 31, 2020 · 7 comments
Closed
3 tasks done

[Roadmap] 1.1.1 Patch Release #5735

hcho3 opened this issue May 31, 2020 · 7 comments

Comments

@hcho3
Copy link
Collaborator

hcho3 commented May 31, 2020

We are looking to release a patch release 1.1.1, primarily to benefit from CPU performance improvement in the PyPI wheels (#5720). I'd like to know if there are other patches that should go into 1.1.1.

@dmlc/xgboost-committer

List of patches:

@hcho3 hcho3 pinned this issue May 31, 2020
@kongzii
Copy link
Contributor

kongzii commented Jun 2, 2020

I am not sure that this counts as a patch, but if so, it would be awesome to have it in the release: #5744

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 2, 2020

@kongzii The patch release will be released as compiled binaries. Wouldn't someone who want to use pkgconfig be compiling XGBoost from the source? Not sure what would be a benefit to backport #5744 to the patch release.

@kongzii
Copy link
Contributor

kongzii commented Jun 2, 2020

@hcho3 I thought that if it would be in the patch release, then doing brew install xgboost would add pkg-config along with it, or do I need to do another update for it to work like that?
And there are also branches for releases, so git checkout release_1.1.1 would have pkg-config in it.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 2, 2020

@kongzii Ah I forgot about Homebrew. Yes, indeed, Homebrew will run make install and install the pkg-config. We'll add it to the release.

@kongzii
Copy link
Contributor

kongzii commented Jun 2, 2020

Thank you 👍

@SmirnovEgorRu
Copy link
Contributor

@hcho3, I suppose we can close the first task, performance of this was checked by @ShvetsKS

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 7, 2020

1.1.1 is now available from PyPI. To install, run python -m pip install xgboost==1.1.1.

@hcho3 hcho3 closed this as completed Jun 7, 2020
@hcho3 hcho3 unpinned this issue Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants