-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move linter to Jenkins. #4032
Comments
Regenerated with both host and device checking: |
Requirements:
@RAMitchell @hcho3 Do you think it's worthy? |
You dont have to refactor the lint errors all in one go. What if you set up the system on jenkins but allow it to pass even with errors, spend a couple of weeks fixing lint issues, then make it mandatory. I think this is very much worth doing. |
Closing. PR is here #4034 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the linter is a good hack, but not reliable due to the fact that clang-tidy doesn't deal well with CUDA source code. On Travis our linter script renames all cu files into cc files and perform clang-tidy checks, which leads to incorrect results, see the end of:
https://travis-ci.org/dmlc/xgboost/jobs/473251478
Now we have CUDA runtime on Jenkins thanks to @hcho3 , where we can use clang-tidy without such hack. The correct clang-tidy results I generated is attached.
log-tidy.txt
The text was updated successfully, but these errors were encountered: