Skip to content

Commit 0ccf8b4

Browse files
authored
build: add libmxnet.so into lib search list. (#424)
In case of macOS, if user build libmxnet from source set MXNET_HOME, the output is still named as `libmxnet.so`. Ref: #423
1 parent 3df1214 commit 0ccf8b4

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

deps/build.jl

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ if haskey(ENV, "MXNET_HOME")
1111
MXNET_HOME = ENV["MXNET_HOME"]
1212
info("MXNET_HOME environment detected: $MXNET_HOME")
1313
info("Trying to load existing libmxnet...")
14-
lib = Libdl.find_library("libmxnet.$(Libdl.dlext)",
14+
# In case of macOS, if user build libmxnet from source and set the MXNET_HOME,
15+
# the output is still named as `libmxnet.so`.
16+
lib = Libdl.find_library(["libmxnet.$(Libdl.dlext)", "libmxnet.so"],
1517
[joinpath(MXNET_HOME, "lib"), MXNET_HOME])
1618
if !isempty(lib)
1719
info("Existing libmxnet detected at $lib, skip building...")

src/base.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const grad_req_map = Dict{Symbol,GRAD_REQ}(
3030
################################################################################
3131
# Initialization and library API entrance
3232
################################################################################
33-
const MXNET_LIB = Libdl.find_library("libmxnet.$(Libdl.dlext)",
33+
const MXNET_LIB = Libdl.find_library(["libmxnet.$(Libdl.dlext)", "libmxnet.so"], # see build.jl
3434
[joinpath(get(ENV, "MXNET_HOME", ""), "lib"),
3535
get(ENV, "MXNET_HOME", ""),
3636
Pkg.dir("MXNet", "deps", "usr", "lib")])

0 commit comments

Comments
 (0)