Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThemePackage.getStylesheetsPath is deprecated. #19

Open
moakdesigns opened this issue Jun 4, 2015 · 6 comments
Open

ThemePackage.getStylesheetsPath is deprecated. #19

moakdesigns opened this issue Jun 4, 2015 · 6 comments

Comments

@moakdesigns
Copy link

Store package style sheets in the styles/ directory instead of stylesheets/ in the atom-soda-dark-ui package

ThemePackage.getStylesheetsPath (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:458:9)
ThemePackage.getStylesheetPaths (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:469:32)
ThemePackage.loadStylesheets (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:451:38)
<unknown> (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\theme-package.js:47:19)
ThemePackage.measure (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\package.js:163:15)
ThemePackage.activate (C:\Users\jmoakley\AppData\Local\atom\app-0.205.0\resources\app.asar\src\theme-package.js:43:12)
@bencagri
Copy link

bencagri commented Jun 5, 2015

+1

1 similar comment
@vercas
Copy link
Contributor

vercas commented Jun 26, 2015

👍

@dmackerman
Copy link
Owner

Hey guys, haven't had much time to maintain this unfortunately. Would love a PR!

@vercas
Copy link
Contributor

vercas commented Jun 26, 2015

Would this be alright? (check the last 3 commits)
If so, I'll submit a pull request.

I've got no means of testing my changes currently. 😞

@dmackerman
Copy link
Owner

Looks good to me.

@vercas
Copy link
Contributor

vercas commented Jun 29, 2015

Check out #20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants