-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional categories #446
base: master
Are you sure you want to change the base?
Conversation
Categories for Cloud and Business apps
Thanks for your pull request and interest in making D better, @UI-Manufaktur! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to include brand names in the categories list.
This also currently fails to adhere to the trademark usage guidelines of some products, as it also needs notes about for example "<SAP TRADEMARKS> is/are the trademark(s) or registered trademark(s) of SAP SE in Germany and in several other countries."
and the ® or ™ symbols depending on the name.
I'm for adding cloud
, business
and probably also erp
but I don't think it's a good idea to include brand names. Also there aren't that many libraries and applications fitting in these categories currently so I think the broad categories are enough to be descriptive.
]}, | ||
{"name": "cloud", "description": "Cloud solutions", "categories": [ | ||
{"name": "azure", "description": "Azure cloud solutions"}, | ||
{"name": "aws", "description": "AWS Azure cloud solutions"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you put a wrong description here (added Azure)
{"name": "aws", "description": "AWS Azure cloud solutions"}, | |
{"name": "aws", "description": "Amazon Web Services cloud solutions"}, |
{"name": "business", "description": "Business applications", "categories": [ | ||
{"name": "sap", "description": "SAP solutions"}, | ||
{"name": "salesforce", "description": "Salesforce solutions"}, | ||
{"name": "workday", "description": "Workday solutions"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about putting all of these 3 categories in a parent category called "ERP software"
or similar
Categories for Cloud and Business apps