Skip to content

Commit f33be1e

Browse files
PeteAndersenfelixxm
authored andcommitted
[2.2.x] Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs.
Backport of 02eff7e from master
1 parent e8b0903 commit f33be1e

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

django/forms/widgets.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -522,9 +522,7 @@ def format_value(self, value):
522522

523523
def get_context(self, name, value, attrs):
524524
if self.check_test(value):
525-
if attrs is None:
526-
attrs = {}
527-
attrs['checked'] = True
525+
attrs = {**(attrs or {}), 'checked': True}
528526
return super().get_context(name, value, attrs)
529527

530528
def value_from_datadict(self, data, files, name):

tests/forms_tests/widget_tests/test_checkboxinput.py

+5
Original file line numberDiff line numberDiff line change
@@ -89,3 +89,8 @@ def test_value_from_datadict_string_int(self):
8989
def test_value_omitted_from_data(self):
9090
self.assertIs(self.widget.value_omitted_from_data({'field': 'value'}, {}, 'field'), False)
9191
self.assertIs(self.widget.value_omitted_from_data({}, {}, 'field'), False)
92+
93+
def test_get_context_does_not_mutate_attrs(self):
94+
attrs = {'checked': False}
95+
self.widget.get_context('name', True, attrs)
96+
self.assertIs(attrs['checked'], False)

tests/postgres_tests/test_array.py

+11
Original file line numberDiff line numberDiff line change
@@ -917,6 +917,17 @@ def test_get_context(self):
917917
}
918918
)
919919

920+
def test_checkbox_get_context_attrs(self):
921+
context = SplitArrayWidget(
922+
forms.CheckboxInput(),
923+
size=2,
924+
).get_context('name', [True, False])
925+
self.assertEqual(context['widget']['value'], '[True, False]')
926+
self.assertEqual(
927+
[subwidget['attrs'] for subwidget in context['widget']['subwidgets']],
928+
[{'checked': True}, {}]
929+
)
930+
920931
def test_render(self):
921932
self.check_html(
922933
SplitArrayWidget(forms.TextInput(), size=2), 'array', None,

0 commit comments

Comments
 (0)