Skip to content

Commit b9c36b5

Browse files
committed
Rebase on master and migrate url function to re_path
1 parent a41a465 commit b9c36b5

File tree

4 files changed

+16
-24
lines changed

4 files changed

+16
-24
lines changed

oauth2_provider/urls.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
]
2929

3030
oidc_urlpatterns = [
31-
url(r"^\.well-known/openid-configuration/$", views.ConnectDiscoveryInfoView.as_view(),
31+
re_path(r"^\.well-known/openid-configuration/$", views.ConnectDiscoveryInfoView.as_view(),
3232
name="oidc-connect-discovery-info"),
33-
url(r"^jwks/$", views.JwksInfoView.as_view(), name="jwks-info"),
34-
url(r"^userinfo/$", views.UserInfoView.as_view(), name="user-info")
33+
re_path(r"^jwks/$", views.JwksInfoView.as_view(), name="jwks-info"),
34+
re_path(r"^userinfo/$", views.UserInfoView.as_view(), name="user-info")
3535
]
3636

3737

oauth2_provider/views/introspect.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from django.views.decorators.csrf import csrf_exempt
88

99
from oauth2_provider.models import get_access_token_model
10-
from oauth2_provider.views import ClientProtectedScopedResourceView
10+
from oauth2_provider.views.generic import ClientProtectedScopedResourceView
1111

1212

1313
@method_decorator(csrf_exempt, name="dispatch")

tests/test_implicit.py

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -317,18 +317,16 @@ def test_id_token_skip_authorization_completely(self):
317317
self.application.skip_authorization = True
318318
self.application.save()
319319

320-
query_string = urlencode({
320+
query_data = {
321321
"client_id": self.application.client_id,
322322
"response_type": "id_token",
323323
"state": "random_state_string",
324324
"nonce": "random_nonce_string",
325325
"scope": "openid",
326326
"redirect_uri": "http://example.org",
327-
})
328-
329-
url = "{url}?{qs}".format(url=reverse("oauth2_provider:authorize"), qs=query_string)
327+
}
330328

331-
response = self.client.get(url)
329+
response = self.client.get(reverse("oauth2_provider:authorize"), data=query_data)
332330
self.assertEqual(response.status_code, 302)
333331
self.assertIn("http://example.org#", response["Location"])
334332
self.assertNotIn("access_token=", response["Location"])
@@ -351,17 +349,15 @@ def test_id_token_skip_authorization_completely_missing_nonce(self):
351349
self.application.skip_authorization = True
352350
self.application.save()
353351

354-
query_string = urlencode({
352+
query_data = {
355353
"client_id": self.application.client_id,
356354
"response_type": "id_token",
357355
"state": "random_state_string",
358356
"scope": "openid",
359357
"redirect_uri": "http://example.org",
360-
})
361-
362-
url = "{url}?{qs}".format(url=reverse("oauth2_provider:authorize"), qs=query_string)
358+
}
363359

364-
response = self.client.get(url)
360+
response = self.client.get(reverse("oauth2_provider:authorize"), data=query_data)
365361
self.assertEqual(response.status_code, 302)
366362
self.assertIn("error=invalid_request", response["Location"])
367363
self.assertIn("error_description=Request+is+missing+mandatory+nonce+paramete", response["Location"])
@@ -425,18 +421,16 @@ def test_access_token_and_id_token_skip_authorization_completely(self):
425421
self.application.skip_authorization = True
426422
self.application.save()
427423

428-
query_string = urlencode({
424+
query_data = {
429425
"client_id": self.application.client_id,
430426
"response_type": "id_token token",
431427
"state": "random_state_string",
432428
"nonce": "random_nonce_string",
433429
"scope": "openid",
434430
"redirect_uri": "http://example.org",
435-
})
436-
437-
url = "{url}?{qs}".format(url=reverse("oauth2_provider:authorize"), qs=query_string)
431+
}
438432

439-
response = self.client.get(url)
433+
response = self.client.get(reverse("oauth2_provider:authorize"), data=query_data)
440434
self.assertEqual(response.status_code, 302)
441435
self.assertIn("http://example.org#", response["Location"])
442436
self.assertIn("access_token=", response["Location"])

tests/urls.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
from django.conf.urls import include, url
1+
from django.urls import include, re_path
22
from django.contrib import admin
33

44

55
admin.autodiscover()
66

77

88
urlpatterns = [
9-
url(r"^o/", include("oauth2_provider.urls", namespace="oauth2_provider")),
9+
re_path(r"^o/", include("oauth2_provider.urls", namespace="oauth2_provider")),
10+
re_path(r"^admin/", admin.site.urls),
1011
]
11-
12-
13-
urlpatterns += [url(r"^admin/", admin.site.urls)]

0 commit comments

Comments
 (0)