Skip to content

Commit 043e5d3

Browse files
fladijleclanche
authored andcommitted
Parse URI only once in AbstractApplication.redirect_uri_allowed.
Just a minor inconvenience but it seems unnecessary to me to parse the same parameter value multiple times in case there are more than one permitted redirect URIs.
1 parent 4e2dfa0 commit 043e5d3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

oauth2_provider/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,16 @@ def redirect_uri_allowed(self, uri):
108108
109109
:param uri: Url to check
110110
"""
111+
parsed_uri = urlparse(uri)
112+
uqs_set = set(parse_qsl(parsed_uri.query))
111113
for allowed_uri in self.redirect_uris.split():
112114
parsed_allowed_uri = urlparse(allowed_uri)
113-
parsed_uri = urlparse(uri)
114115

115116
if (parsed_allowed_uri.scheme == parsed_uri.scheme and
116117
parsed_allowed_uri.netloc == parsed_uri.netloc and
117118
parsed_allowed_uri.path == parsed_uri.path):
118119

119120
aqs_set = set(parse_qsl(parsed_allowed_uri.query))
120-
uqs_set = set(parse_qsl(parsed_uri.query))
121121

122122
if aqs_set.issubset(uqs_set):
123123
return True

0 commit comments

Comments
 (0)