basic sync message sending

Author: dizer

lib/eureka-bot.rb

@@ -14,6 +14,7 @@ module EurekaBot
   autoload :Instrumentation
   autoload :Job
   autoload :Resolver
+  autoload :Sender
   autoload :Version
 
   eager_autoload do

lib/eureka_bot/controller/response.rb

@@ -11,15 +11,18 @@ def initialize(logger: EurekaBot.logger)
     @order_counters = {}
   end
 
-  def add(**params)
+  def add(sync: false, **params)
     run_callbacks :add do
-      if params[:order_queue]
-        @order_counters[params[:order_queue]] = (@order_counters[params[:order_queue]] || 0) + 1
-        @data << {
-            order: @order_counters[params[:order_queue]]
-        }.merge(params)
+      message = params
+      if message[:order_queue]
+        @order_counters[message[:order_queue]] = (@order_counters[message[:order_queue]] || 0) + 1
+        message = {order: @order_counters[message[:order_queue]]}.merge(message)
+      end
+      if sync
+        self.class.sender_class.new.deliver(message)
       else
-        @data << params
+        @data << message
+        nil
       end
     end
   end
@@ -32,4 +35,8 @@ def to_a
     data
   end
 
+  def self.sender_class
+    @@sender_class ||= EurekaBot::Sender
+  end
+
 end

lib/eureka_bot/sender.rb

@@ -0,0 +1,8 @@
+class EurekaBot::Sender
+  include EurekaBot::Instrumentation
+
+  def deliver(message)
+    true
+  end
+
+end

lib/eureka_bot/version.rb

@@ -1,3 +1,3 @@
 module EurekaBot
-  VERSION = '1.0.15'
+  VERSION = '1.0.16'
 end

spec/eureka-bot/instrumentation_spec.rb

@@ -5,12 +5,14 @@
     let(:resolver) { EurekaBot::Resolver.new(message: {}) }
     it do
       payloads = []
-      ActiveSupport::Notifications.subscribe /.*/ do |name, started, finished, id, payload|
+      subscriber = ActiveSupport::Notifications.subscribe /.*/ do |name, started, finished, id, payload|
         expect(payload).to include(:level)
         payloads << payload
       end
 
       expect{resolver.resolved}.to change{payloads.length}.from(0).to(1)
+
+      ActiveSupport::Notifications.unsubscribe(subscriber)
     end
   end
 end

spec/eureka-bot/job_spec.rb

@@ -72,9 +72,5 @@ def some_action
         }.to change{$result}.from(nil).to('test action error')
       end
     end
-
-
-
-
   end
 end