Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of drag feature doesn't work. #76

Open
DimitriChauvel opened this issue Sep 29, 2022 · 1 comment
Open

Test of drag feature doesn't work. #76

DimitriChauvel opened this issue Sep 29, 2022 · 1 comment
Assignees

Comments

@DimitriChauvel
Copy link
Member

DimitriChauvel commented Sep 29, 2022

Describe the bug

Move testing doesn't work with the new drag system developed with interactjs

To Reproduce

Steps to reproduce the behavior:

  1. Go to feature/drag_and_drop_container
  2. Remove line 7 in cypress/e2e/move.feature
  3. Run demo: npm run demo
  4. Run Cypress: npx cypress open

Additional Context

I think trouble comes from to cypress/e2e/drag-support.js, maybe cause position data of components is incremented by the event.dx and event.dy (dx and dy are equal to the new mouse position minus the last saved mouse position) of interactjs. Before that we saved at each event, in the position data, just the mouse position minus the delta between the mouse and the component origin. So there was no need for intermediate data.

@sohzaz
Copy link
Member

sohzaz commented Oct 4, 2022

After investigation:

  1. The interactjs library seems to completely ignore mouse events triggered by cypress, only fix I can see is not using interactjs.
  2. The test case itself does not work when reproduced manually, stacking #external1 on top of #network1 does not add it to the latter's children list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants