Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify initial code contributions #10

Closed
heuermh opened this issue Apr 19, 2018 · 9 comments
Closed

Identify initial code contributions #10

heuermh opened this issue Apr 19, 2018 · 9 comments
Milestone

Comments

@heuermh
Copy link
Contributor

heuermh commented Apr 19, 2018

No description provided.

@heuermh heuermh changed the title Discuss initial code contributions Identify initial code contributions Apr 19, 2018
@heuermh
Copy link
Contributor Author

heuermh commented May 22, 2018

@heuermh
Copy link
Contributor Author

heuermh commented Jul 18, 2018

I'm willing to help migrate the following
https://github.com/bigdatagenomics/convert

and any of the modules in
https://github.com/heuermh/dishevelled-bio

Longer term, as scope increases, bits of the following might be fair game
https://github.com/bigdatagenomics/adam
https://github.com/bigdatagenomics/bdg-formats
https://github.com/bigdatagenomics/utils

Relicensing contributions from dishevelled-bio (LGPL 3.0) would be relatively easy, as it is single-author. adam, bdg-formatics, convert, and utils are all Apache 2 and multi-author, so the process would be more difficult (though easier if disq were also licensed Apache 2).

@tomwhite
Copy link
Member

I would like to transfer https://github.com/tomwhite/disq over to here. One way would be to move the repository, which keeps the history. Alternatively I can prepare a PR.

@heuermh
Copy link
Contributor Author

heuermh commented Jul 19, 2018

I would prefer a pull request so that we can code review on the way in.

@magicDGS
Copy link
Contributor

In that case, would it be small PRs with concrete functionality for easier review or all the code at once?

@tomwhite
Copy link
Member

I've opened #14. It's not obvious how to break it into pieces, so I would suggest looking at it as it stands.

@magicDGS
Copy link
Contributor

Maybe README/pom/NOTICE/gitignore and non-code files could be separated; the samtools package can be in one PR (as it is independent) and then each package in a different one - #14 looks like a hard PR to review...

@tomwhite
Copy link
Member

@magicDGS The samtools package does not really need reviewing (or at least not here) as it is a copy of the files in samtools/htsjdk#1138 - it's a short-term expedient until that PR gets reviewed and released.

I'll think a bit more about splitting up the packages, but I fear they are quite interconnected.

@heuermh
Copy link
Contributor Author

heuermh commented Sep 4, 2018

Closed by #14.

@heuermh heuermh closed this as completed Sep 4, 2018
@heuermh heuermh added this to the 0.1.0 milestone Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants