Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for non-P2WPKH Funding Inputs #52

Closed
nkohen opened this issue Aug 6, 2020 · 1 comment
Closed

Support for non-P2WPKH Funding Inputs #52

nkohen opened this issue Aug 6, 2020 · 1 comment
Labels
contract-negotiation
Milestone
v0.1

Comments

@nkohen
Copy link
Contributor

nkohen commented Aug 6, 2020

Specifically support for nested P2SH(Segwit) and native P2WSH because funding inputs must still be Segwit inputs.

As of #51 fee computation is made simpler by assuming that all funding inputs are P2WPKH. In the future we want to include input info fields in our contract negotiation (similar to the proposal for LN dual-funded channels) which contain fee information so that computation can be done more accurately while staying deterministic.
@nkohen nkohen added this to the v0.1 milestone Aug 6, 2020
@nkohen nkohen mentioned this issue Aug 6, 2020
Closed
4 tasks
@nkohen nkohen mentioned this issue Aug 17, 2020
Merged
1 task
@nkohen
Copy link
Contributor Author

nkohen commented Sep 29, 2020

Closed by #81

@nkohen nkohen closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contract-negotiation
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@nkohen