Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message updates new message shouldn't be partial #10525

Closed
Amgelo563 opened this issue Sep 30, 2024 · 0 comments · Fixed by #10526
Closed

Message updates new message shouldn't be partial #10525

Amgelo563 opened this issue Sep 30, 2024 · 0 comments · Fixed by #10526

Comments

@Amgelo563
Copy link
Contributor

Amgelo563 commented Sep 30, 2024

Which application or package is this feature request for?

discord.js

Feature

According to discord/discord-api-docs#7017 the message update payload is no longer a partial object, but rather the full message object.

As such, the ClientEvents#messageUpdate's newMessage shouldn't be typed as a partial anymore.

I think it'd also require updating the MessageUpdate action so it no longer accounts for partials on the message received, but I'm not so sure about that part. Upon discussion with staff, this isn't the case.

Ideal solution or implementation

For ClientEvents#messageUpdate's newMessage to no longer be typed as Message | PartialMessage, but rather just Message.

Alternative solutions or implementations

No response

Other context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants