-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user-installable apps #921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Mar 23, 2024
- integration_types is always optional - contexts is always optional - contexts is nullable except when creating or editing an application command
3 tasks
The last issue just got resolved. 👀 |
- Remove non-string value in `authorizing_integration_owners` - Preserve documentation for `contexts` - `APIMessageInteractionMetadata` `user_id` -> `user`
Types now match the API and docs. I'm unsure if this should be merged (as the docs say: "API details are subject to change.") but I'll leave it up to the maintainers to decide. If not yet, I'll keep this updated with changes. |
You can mark it as |
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds in the new fields & deprecation changes from https://discord.com/developers/docs/change-log#userinstallable-apps-preview
Now you can make user-installable apps with type-safety :)
Marked as draft until these issues are resolved, since what the API returns and what the docs say is different (current PR matches the API, will update based on issues):
integration_types
andcontexts
are both documented as non-nullable with defaults, butcontexts
can benull
discord/discord-api-docs#6744authorizing_integration_owners
discord/discord-api-docs#6730If applicable, please reference Discord API Docs PRs or commits that influenced this PR: