Skip to content

Commit 9ddd922

Browse files
authored
[Refactor] Refactor some stuff (#2688)
* fix some `internal` classes being exposed * update xmldoc comments to use `<see langword>` * bump library version in samples * fix possible oversight
1 parent fe4130d commit 9ddd922

File tree

119 files changed

+326
-324
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+326
-324
lines changed

samples/BasicBot/_BasicBot.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Discord.Net.WebSocket" Version="3.8.1"/>
9+
<PackageReference Include="Discord.Net.WebSocket" Version="3.10.0"/>
1010
</ItemGroup>
1111

1212
</Project>

samples/InteractionFramework/_InteractionFramework.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="5.0.0" />
1414
<PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="5.0.0" />
1515
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="5.0.2" />
16-
<PackageReference Include="Discord.Net.Interactions" Version="3.8.1" />
16+
<PackageReference Include="Discord.Net.Interactions" Version="3.10.0" />
1717
</ItemGroup>
1818

1919
</Project>

samples/ShardedClient/_ShardedClient.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="5.0.2" />
11-
<PackageReference Include="Discord.Net" Version="3.8.1" />
11+
<PackageReference Include="Discord.Net" Version="3.10.0" />
1212
</ItemGroup>
1313

1414
</Project>

samples/TextCommandFramework/_TextCommandFramework.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="5.0.2" />
11-
<PackageReference Include="Discord.Net.Commands" Version="3.8.1" />
12-
<PackageReference Include="Discord.Net.Websocket" Version="3.8.1" />
11+
<PackageReference Include="Discord.Net.Commands" Version="3.10.0" />
12+
<PackageReference Include="Discord.Net.Websocket" Version="3.10.0" />
1313
</ItemGroup>
1414

1515
</Project>

samples/WebhookClient/_WebhookClient.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
</PropertyGroup>
88

99
<ItemGroup>
10-
<PackageReference Include="Discord.Net.Webhook" Version="3.8.1" />
10+
<PackageReference Include="Discord.Net.Webhook" Version="3.10.0" />
1111
</ItemGroup>
1212

1313
</Project>

src/Discord.Net.Commands/Attributes/PreconditionAttribute.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public abstract class PreconditionAttribute : Attribute
1515
/// </summary>
1616
/// <remarks>
1717
/// <see cref="Preconditions" /> of the same group require only one of the preconditions to pass in order to
18-
/// be successful (A || B). Specifying <see cref="Group" /> = <c>null</c> or not at all will
18+
/// be successful (A || B). Specifying <see cref="Group" /> = <see langword="null" /> or not at all will
1919
/// require *all* preconditions to pass, just like normal (A &amp;&amp; B).
2020
/// </remarks>
2121
public string Group { get; set; } = null;

src/Discord.Net.Commands/CommandService.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public async Task<ModuleInfo> CreateModuleAsync(string primaryAlias, Action<Modu
163163
/// </code>
164164
/// </example>
165165
/// <typeparam name="T">The type of module.</typeparam>
166-
/// <param name="services">The <see cref="IServiceProvider"/> for your dependency injection solution if using one; otherwise, pass <c>null</c>.</param>
166+
/// <param name="services">The <see cref="IServiceProvider"/> for your dependency injection solution if using one; otherwise, pass <see langword="null" />.</param>
167167
/// <exception cref="ArgumentException">This module has already been added.</exception>
168168
/// <exception cref="InvalidOperationException">
169169
/// The <see cref="ModuleInfo"/> fails to be built; an invalid type may have been provided.
@@ -178,7 +178,7 @@ public async Task<ModuleInfo> CreateModuleAsync(string primaryAlias, Action<Modu
178178
/// Adds a command module from a <see cref="Type" />.
179179
/// </summary>
180180
/// <param name="type">The type of module.</param>
181-
/// <param name="services">The <see cref="IServiceProvider" /> for your dependency injection solution if using one; otherwise, pass <c>null</c> .</param>
181+
/// <param name="services">The <see cref="IServiceProvider" /> for your dependency injection solution if using one; otherwise, pass <see langword="null" /> .</param>
182182
/// <exception cref="ArgumentException">This module has already been added.</exception>
183183
/// <exception cref="InvalidOperationException">
184184
/// The <see cref="ModuleInfo"/> fails to be built; an invalid type may have been provided.
@@ -217,7 +217,7 @@ public async Task<ModuleInfo> AddModuleAsync(Type type, IServiceProvider service
217217
/// Add command modules from an <see cref="Assembly"/>.
218218
/// </summary>
219219
/// <param name="assembly">The <see cref="Assembly"/> containing command modules.</param>
220-
/// <param name="services">The <see cref="IServiceProvider"/> for your dependency injection solution if using one; otherwise, pass <c>null</c>.</param>
220+
/// <param name="services">The <see cref="IServiceProvider"/> for your dependency injection solution if using one; otherwise, pass <see langword="null" />.</param>
221221
/// <returns>
222222
/// A task that represents the asynchronous operation for adding the command modules. The task result
223223
/// contains an enumerable collection of modules added.

src/Discord.Net.Commands/Extensions/MessageExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public static class MessageExtensions
1414
/// <param name="c">The char prefix.</param>
1515
/// <param name="argPos">References where the command starts.</param>
1616
/// <returns>
17-
/// <c>true</c> if the message begins with the char <paramref name="c"/>; otherwise <c>false</c>.
17+
/// <see langword="true" /> if the message begins with the char <paramref name="c"/>; otherwise <see langword="false" />.
1818
/// </returns>
1919
public static bool HasCharPrefix(this IUserMessage msg, char c, ref int argPos)
2020
{

src/Discord.Net.Commands/ModuleBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public abstract class ModuleBase<T> : IModuleBase
3434
/// <param name="embed">An embed to be displayed alongside the <paramref name="message"/>.</param>
3535
/// <param name="allowedMentions">
3636
/// Specifies if notifications are sent for mentioned users and roles in the <paramref name="message"/>.
37-
/// If <c>null</c>, all mentioned roles and users will be notified.
37+
/// If <see langword="null" />, all mentioned roles and users will be notified.
3838
/// </param>
3939
/// <param name="options">The request options for this <see langword="async"/> request.</param>
4040
/// <param name="messageReference">The message references to be included. Used to reply to specific messages.</param>

src/Discord.Net.Commands/Results/ExecuteResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public static ExecuteResult FromError(IResult result)
7676
/// Gets a string that indicates the execution result.
7777
/// </summary>
7878
/// <returns>
79-
/// <c>Success</c> if <see cref="IsSuccess"/> is <c>true</c>; otherwise "<see cref="Error"/>:
79+
/// <c>Success</c> if <see cref="IsSuccess"/> is <see langword="true" />; otherwise "<see cref="Error"/>:
8080
/// <see cref="ErrorReason"/>".
8181
/// </returns>
8282
public override string ToString() => IsSuccess ? "Success" : $"{Error}: {ErrorReason}";

0 commit comments

Comments
 (0)