Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this source: re-library.com (novelupdates links only) #2160

Closed
arromdee opened this issue Oct 9, 2023 · 3 comments
Closed

Fix this source: re-library.com (novelupdates links only) #2160

arromdee opened this issue Oct 9, 2023 · 3 comments

Comments

@arromdee
Copy link

arromdee commented Oct 9, 2023

Yes I searched the existing issues.

Novel URL: https://www.novelupdates.com/series/after-genderswap-reincarnation-i-raised-the-strongest-player/
App Location: PIP
App Version: 3.3.0

lncrawl is not able to download anything from novelupdates.com that links to re-library.com, even though it is able to download directly from re-library.com. If you try the above location you'll find that the first 11 chapters link to re-library but they link to an intro page with "click here to start reading". So the resulting downloaded novel only contains the intro page and "click here to start reading".
lncrawl should check for this and follow the second link to the actual chapter. (If it can't find the chapter link, of course you should still show the intro page.)

Using lncrawl directly on https://re-library.com/translations/strongest-player-cultivation/ works because that goes directly to the chapters.

@nd2024
Copy link
Contributor

nd2024 commented Oct 18, 2023

I think this is not the problem of the crawler, I checked the novelupdates url you give and there's no link there on every chapter.

image

@arromdee
Copy link
Author

Novelupdates has been changed to require logging in. lncrawl is capable of handling this.

Once you're logged in, the links work, but the problem that I described happens for Re: Library links.

@CryZFix
Copy link
Contributor

CryZFix commented Oct 21, 2023

The problem you describe is related to the fact that with updatenovels crawler gets to the re-library page with a teaser of chapters, not with their list. Therefore, it captures only the text of the teaser and the proposal to start reading.

Please wait a bit, let's see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants