From 66c7b16b32c0ee545676289db4d5326ff87a5dd8 Mon Sep 17 00:00:00 2001
From: Ding Li <dingmaotu@126.com>
Date: Wed, 11 Apr 2018 22:48:34 +0800
Subject: [PATCH] Fix #29: make Vector 
emove have consistent behavior with the
 rest of Collection derived classes

---
 Collection/Vector.mqh | 11 ++++++++---
 Trade/OrderGroup.mqh  |  2 +-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/Collection/Vector.mqh b/Collection/Vector.mqh
index 46b33f1..783efd8 100644
--- a/Collection/Vector.mqh
+++ b/Collection/Vector.mqh
@@ -109,10 +109,15 @@ public:
             if(i!=j) { m_array[i]=m_array[j]; }
             i++;
            }
-         // in this case, it is no point to check m_owned and SafeDelete value
         }
-      if(i<s) ArrayResize(m_array,i);
-      return ((s-i)> 0);
+      if(i<s)
+        {
+         ArrayResize(m_array,i);
+         // to conform to Collection semantics, a removed value should be deleted if it is owned
+         if(m_owned) SafeDelete(value);
+         return true;
+        }
+      return false;
      }
 
    // Sequence interface
diff --git a/Trade/OrderGroup.mqh b/Trade/OrderGroup.mqh
index 4bf7ded..4dd975f 100644
--- a/Trade/OrderGroup.mqh
+++ b/Trade/OrderGroup.mqh
@@ -125,6 +125,6 @@ void OrderGroup::clearClosed(void)
          set(i,0);
         }
      }
-   removeAll(0);
+   remove(0);
   }
 //+------------------------------------------------------------------+