[WIP] Update to go 1.8.0

Fixes kubernetes#1172

Author: dims

.travis.yml

@@ -4,7 +4,7 @@ sudo: require
 dist: trusty
 
 go:
-  - 1.7.1
+  - 1.8
 go_import_path: k8s.io/minikube
 
 install:

BUILD_GUIDE.md

@@ -1,5 +1,5 @@
 ### Build Requirements
-* A recent Go distribution (>1.7)
+* A recent Go distribution (>=1.8)
 * If you're not on Linux, you'll need a Docker installation
 * Minikube requires at least 4GB of RAM to compile, which can be problematic when using docker-machine
 

Makefile

@@ -21,7 +21,7 @@ DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD)
 INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1)
 BUILDROOT_BRANCH ?= 2016.08
 REGISTRY?=gcr.io/k8s-minikube
-DARWIN_BUILD_IMAGE ?= karalabe/xgo-1.7.3
+DARWIN_BUILD_IMAGE ?= karalabe/xgo-1.8.1
 ISO_BUILD_IMAGE ?= $(REGISTRY)/buildroot-image
 
 # The iso will be versioned the same as minikube
@@ -33,7 +33,7 @@ GOARCH ?= $(shell go env GOARCH)
 BUILD_DIR ?= ./out
 ORG := k8s.io
 REPOPATH ?= $(ORG)/minikube
-BUILD_IMAGE ?= gcr.io/google_containers/kube-cross:v1.7.1-0
+BUILD_IMAGE ?= gcr.io/google_containers/kube-cross:v1.8.1-1
 IS_EXE ?=
 
 ifeq ($(IN_DOCKER),1)

hack/jenkins/minikube_cross_build_and_upload.sh

@@ -35,16 +35,40 @@ if out="$(git diff ${ghprbActualCommit} --name-only $(git merge-base origin/mast
 	make release-iso
 fi
 
+# Fetch the gimme script
+curl -sL -o $(pwd)/gimme https://raw.githubusercontent.com/travis-ci/gimme/master/gimme
+chmod +x $(pwd)/gimme
+
+# Check what's on the build machine
+go version
+
+# Install the go 1.8
+export GIMME_GO_VERSION=1.8
+$(pwd)/gimme
+source $HOME/.gimme/envs/go1.8.env
+export GOROOT=$HOME/.gimme/versions/go1.8.linux.amd64/
+
+# Check the version
+go version
 
 # Build all platforms (Windows, Linux, OSX)
 make cross
 
+# Debug
+env
+date
+
 # Build the e2e test target for Darwin and Linux. We don't run tests on Windows yet.
 # We build these on Linux, but run the tests on different platforms.
 # This makes it easier to provision slaves, since they don't need to have a go toolchain.'
-GOPATH=$(pwd)/_gopath GOOS=darwin GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-darwin-amd64
-GOPATH=$(pwd)/_gopath GOOS=linux GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-linux-amd64
-GOPATH=$(pwd)/_gopath GOOS=windows GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-windows-amd64.exe
+echo "Compiling GOOS=linux GOARCH=amd64"
+GOPATH=$(pwd)/_gopath:$HOME/go GOOS=linux GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-linux-amd64
+
+echo "Compiling GOOS=darwin GOARCH=amd64"
+GOPATH=$(pwd)/_gopath:$HOME/go GOOS=darwin GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-darwin-amd64
+
+echo "Compiling GOOS=windows GOARCH=amd64"
+GOPATH=$(pwd)/_gopath:$HOME/go GOOS=windows GOARCH=amd64 go test -c k8s.io/minikube/test/integration --tags=integration -o out/e2e-windows-amd64.exe
 cp -r test/integration/testdata out/
 
 # Don't upload the buildroot artifacts if they exist

hack/jenkins/minikube_set_pending.sh

@@ -27,7 +27,7 @@
 set -e
 set +x
 
-for job in "OSX-Virtualbox" "OSX-XHyve" "Linux-Virtualbox" "Linux-KVM" "Windows-HyperV"; do
+for job in "OSX-Virtualbox" "Linux-Virtualbox" "Linux-KVM"; do
   target_url="https://storage.googleapis.com/minikube-builds/logs/${ghprbPullId}/${job}.txt"
   curl "https://api.github.com/repos/kubernetes/minikube/statuses/${ghprbActualCommit}?access_token=$access_token" \
     -H "Content-Type: application/json" \

pkg/minikube/service/service.go

@@ -165,7 +165,11 @@ func printURLsForService(c corev1.CoreV1Interface, ip, service, namespace string
 			return nil, err
 		}
 
-		u, err := url.Parse(doc.String())
+		value := doc.String()
+		if !strings.HasPrefix(value, "https://") && !strings.HasPrefix(value, "http://") {
+			value = "https://" + value
+		}
+		u, err := url.Parse(value)
 		if err != nil {
 			return nil, err
 		}

pkg/minikube/service/service_test.go

@@ -242,7 +242,7 @@ func TestPrintURLsForService(t *testing.T) {
 			serviceName:    "mock-dashboard",
 			namespace:      "default",
 			tmpl:           defaultTemplate,
-			expectedOutput: []string{"127.0.0.1:1111", "127.0.0.1:2222"},
+			expectedOutput: []string{"https://127.0.0.1:1111", "https://127.0.0.1:2222"},
 		},
 		{
 			description:    "empty slice for no node ports",
@@ -307,7 +307,7 @@ func TestGetServiceURLs(t *testing.T) {
 				{
 					Namespace: "default",
 					Name:      "mock-dashboard",
-					URLs:      []string{"127.0.0.1:1111", "127.0.0.1:2222"},
+					URLs:      []string{"https://127.0.0.1:1111", "https://127.0.0.1:2222"},
 				},
 				{
 					Namespace: "default",