Parser refuses AFTER CREATE SCHEMA DO

[mrj0]

• pgloader --version

pgloader version "3.6.1"
compiled with SBCL 1.4.15.debian
```

• did you test a fresh compile from the source tree?

No, compilation failed (reported in #1005)

• did you search for other similar issues?

Yes

LOAD DATABASE
    FROM      mysql://
    INTO postgresql://

  WITH max parallel create index = 4, prefetch rows = 2500, on error resume next, workers = 8, concurrency = 8

  set timezone to 'PST8PDT'

  SET PostgreSQL PARAMETERS
        maintenance_work_mem to '128MB',
        work_mem to '12MB',
        search_path to 'staging, public, "$user"'

  SET MySQL PARAMETERS
        net_read_timeout  = '120',
        net_write_timeout = '120'

  CAST
     type datetime to timestamptz using zero-dates-to-null,
     type datetime when default '0000-00-00 00:00:00' to timestamptz using zero-dates-to-null,
     type datetime to timestamptz drop default drop not null using zero-dates-to-null,

     type date when default '0000-00-00' to date using zero-dates-to-null,
     type date to date drop not null drop default using zero-dates-to-null

INCLUDING ONLY TABLE NAMES MATCHING 'user'

BEFORE LOAD DO
    $$ drop schema if exists staging cascade ; $$,
    $$ create schema staging;     $$,
    $$ alter database pgsandbox set search_path to staging, public; $$;

AFTER CREATE SCHEMA DO
    $$ alter table "user" alter column last_login_at drop not null; $$,
    $$ alter table "user" alter column banned_at drop not null; $$;

• pgloader output you obtain

2019-12-18T16:55:05.013000Z LOG pgloader version "3.6.1"
KABOOM!
FATAL error: At 

  
  AFTER CREATE SCHEMA DO
  
  ^ (Line 34, Column 0, Position 1174)

In context COMMANDS:

While parsing COMMANDS. Expected:

     the character Tab
  or the character Newline
  or the character Return
  or the character Space
  or the string "--"
  or the string "/*"
  or the string "load"
An unhandled error condition has been signalled: At

  
  AFTER CREATE SCHEMA DO
  
  ^ (Line 34, Column 0, Position 1174)

In context COMMANDS:

While parsing COMMANDS. Expected:

     the character Tab
  or the character Newline
  or the character Return
  or the character Space
  or the string "--"
  or the string "/*"
  or the string "load"




What I am doing here?

At

  
  AFTER CREATE SCHEMA DO
  
  ^ (Line 34, Column 0, Position 1174)

In context COMMANDS:

While parsing COMMANDS. Expected:

     the character Tab
  or the character Newline
  or the character Return
  or the character Space
  or the string "--"
  or the string "/*"
  or the string "load"

Apologies if I have misunderstood the format but I wasn't able to locate an example of how to use this command.

Thanks!
Mike

[auspex]

I'm certain that's the documented format, Mike. I had the same problem.

[dimitri]

Your command had a problem with an extra semi-colon (terminating the command) before the last section. That said that was not your problem, it's just that I didn't expose the new facility to all the sources parsers. I have now added MySQL source as supported for this clause.

[auspex]

I didn't actually find anything in the documentation about that semicolon—I spent hours comparing a non-working configuration to working ones before I realized there had to be one.

[dimitri]

Yeah documentation kind of makes sense mostly if you know how it works already. I realise that it's quite difficult for me to document my own code in a way that makes sense for people who are discovering the whole thing for the first time. Help needed, documentation Pull Requests welcome!