-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required start and end nodes and allow chatting to subset of pipelines #929
Draft
proteusvacuum
wants to merge
14
commits into
main
Choose a base branch
from
fr/start-end-nodes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add start_nodes everywhere they are needed
Opens up the possibility to test smaller portions of the pipeline
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the requirement that there is always a single
Start
andEnd
node, and that there is an accessible path between them.When building up the pipeline graph, we can now traverse from the start node to the end node, so testing subgraphs of the pipeline in the pipeline builder is now possible by moving where the start and end points to.
This also adds automatically incrementing "New Pipeline" names, and adds a migration to create start and end nodes for existing pipelines.
I also did a refactor of the pipeline tests to make them less verbose and make things a bit easier to read.
User Impact
Users will be required to have start and end nodes in their pipelines which clarifies the flow of data.
Demo
Screencast.from.2024-11-28.13-18-49.mp4
Fixes: #638
Docs