Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include focus styles by default #2

Open
fpapado opened this issue Sep 25, 2019 · 1 comment
Open

Please include focus styles by default #2

fpapado opened this issue Sep 25, 2019 · 1 comment

Comments

@fpapado
Copy link

fpapado commented Sep 25, 2019

Hi!

I've been reading through the source and the blog post on elm-pages.
I noticed while doing so that focus styles are missing.
I feel a bit frustrated by that, because I would like this project to have accessible defaults, and that it is important to have a solid basis if the community centralises on it.

If I understand correctly, elm-ui has layoutWith and FocusStyle to include focus styles.

Would it be possible to include the focus by default? Please let me know if I'm missing something, or you would like any more information.

You can find more about focus styles on the Web Content Accessibility Guidelines. There is also a post by Hidde de Vries on Mozilla Hacks about focus.

@dillonkearns
Copy link
Owner

Hi @fpapado, thank you so much for pointing that out! As we discussed on Twitter, if you get around to it I would very much welcome a PR here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants