Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect the user against massive image loading #271

Open
rodarima opened this issue Oct 7, 2024 · 0 comments
Open

Protect the user against massive image loading #271

rodarima opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request security

Comments

@rodarima
Copy link
Member

rodarima commented Oct 7, 2024

Some news websites have a massive number of images, which are usually designed to be rendered at a reasonable size. However, a failure in parsing some of the constraints in the CSS rules may cause all images to render at a much higher size than intended. This situation causes a spike in CPU and memory usage which may fill all available memory. As a concrete example, in my computer it reaches 1 GiB of memory usage opening a single news page.

We should by default protect the user against this problem (but let them remove the restriction if desired). One option may be to cap the maximum image cache per page, so we stop loading more images if we already reached the limit.

@rodarima rodarima added enhancement New feature or request security labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

1 participant