Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is not working out of the box #20

Open
marcospgp opened this issue Sep 9, 2017 · 4 comments
Open

Code is not working out of the box #20

marcospgp opened this issue Sep 9, 2017 · 4 comments

Comments

@marcospgp
Copy link

So I installed this with composer, and turns out the dependencies were not right. So I changed the composer version to dev-master, and now the code runs without errors but the files are nowhere to be seen.

I spent a few hours trying to fix this issue, to no avail. I decided to try a new backend script afterwards and it worked perfectly.

So I don't know what is wrong specifically but I'm pretty sure this repository isn't working out of the box right now, if you're trying to use it, beware.

@dilab, please see if you can update the code or add some information regarding this on the readme

@vedmant
Copy link

vedmant commented Oct 23, 2017

That's most probably of stupid implementation of SimpleRequest class, it will think that it's get request when you have post request with query.

@adadgio
Copy link
Contributor

adadgio commented Oct 23, 2017

You probably need to run composer install after updating your composer version manually.

Secondly, please try to right in understandable english so that it's possible for us to debug.

Thank you.

@vedmant
Copy link

vedmant commented Oct 23, 2017

@adadgio look at this code

return isset($_GET)&&!empty($_GET);
if will return that request is a get request when it's actually a post if it has a query, like upload.php?foo=bar.

@dilab
Copy link
Owner

dilab commented Oct 24, 2017

@vedmant @adadgio thank you all for the hands-up. a PR is always welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants