FIX: filtering devices fails because mac address filter is a required #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
added a commit
that referenced
this pull request
Dec 7, 2016
lampwins
pushed a commit
to lampwins/netbox
that referenced
this pull request
Oct 13, 2017
…dr_required_from_filter FIX: filtering devices fails because mac address filter is a required
lampwins
pushed a commit
to lampwins/netbox
that referenced
this pull request
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch: develop
Browser: Chrome
Steps to reproduce:
List all Devices to view the Filter Device form.
Hit Submit, it says the MAC address field must be filled out.Noticed the MAC address field has the "required" attribute attached to it.
This simple patch resolves the issue for me.