-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBAAS-3906: Include updatePool for DB Clusters #596
DBAAS-3906: Include updatePool for DB Clusters #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work
databases.go
Outdated
@@ -299,6 +300,14 @@ type DatabaseCreatePoolRequest struct { | |||
Mode string `json:"mode"` | |||
} | |||
|
|||
// DatabaseUpdatePoolRequest is used to update a database connection pool | |||
type DatabaseUpdatePoolRequest struct { | |||
User string `json:"user"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are any of the struct vales within the update request required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, size
, database
, and mode
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit
add `omitempty` on `DatabaseUpdatePoolRequest` User field Co-authored-by: Samuel Guyah <[email protected]>
…nto dbaas/include-update-pool
Adds
updatePool
+ updatesDatabaseService
, allows for Postgres pool updates through godo, makes a PUT request to/v2/databases/$uuid/pools/$poolname
.