apps: add option to get projects data from Apps List endpoint #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ListApps endpoint can be called with a
with_projectsquery parameter to tell it whether or not to fetch the project ids for each project. This is an expensive call which is why it isn't done by default.I'm not sure how to add support for this without breaking changes, I'm hoping @andrewsomething you've got some ideas 🙏 This way seemed like the least work for devs who have already used this in their code, as well as for the doctl implementation of this function.This now is an addition to the ListOptions struct, which shouldn't be a breaking change 👍