Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBAAS-3011: Add new public endpoints for dbaas alerts #564

Merged
merged 4 commits into from
Oct 12, 2022
Merged

DBAAS-3011: Add new public endpoints for dbaas alerts #564

merged 4 commits into from
Oct 12, 2022

Conversation

dweinshenker
Copy link
Contributor

@dweinshenker dweinshenker commented Oct 11, 2022 •
edited
Loading

Adding new public DBAAS rule endpoints to allow doctl to validate when creating/updating rules

@dweinshenker dweinshenker marked this pull request as ready for review October 12, 2022 17:00
andrewsomething
andrewsomething approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

It would be great to get these added to the OpenAPI spec so that they show up in the public API documentation and clients generated from it:

https://github.com/digitalocean/openapi/blob/24d640763881c4d84c5cdab1656e695485e23120/specification/resources/monitoring/models/alert_policy.yml#L44-L60

@andrewsomething andrewsomething merged commit 3c0c036 into digitalocean:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweinshenker @andrewsomething